Skip to content

Format doc comments so they render better in docc #2034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Aug 8, 2023

Add a couple of line breaks to doc comments so they render more nicely in docc.

For example, DO NOT CONFORM TO THIS PROTOCOL YOURSELF! should not show up in the abstract of the base syntax nodes

@ahoppen ahoppen requested a review from bnbarham August 8, 2023 23:00
@ahoppen
Copy link
Member Author

ahoppen commented Aug 8, 2023

@swift-ci Please test

An associated type declaration like the following.
An `associatedtype` declaration

For exmaple, an associatedtype declaration can look like the following.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in example but I think for all these I would just remove everything after For example

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed For example from all these comments

@ahoppen ahoppen force-pushed the ahoppen/format-documentation branch from 8aa710c to f54f5f6 Compare August 9, 2023 03:40
@ahoppen
Copy link
Member Author

ahoppen commented Aug 9, 2023

@swift-ci Please test

@ahoppen ahoppen enabled auto-merge August 9, 2023 03:42
Add a couple of line breaks to doc comments so they render more nicely in docc.

For example, `DO NOT CONFORM TO THIS PROTOCOL YOURSELF!` should not show up in the abstract of the base syntax nodes
@ahoppen ahoppen force-pushed the ahoppen/format-documentation branch from f54f5f6 to 101c441 Compare August 9, 2023 03:50
@ahoppen
Copy link
Member Author

ahoppen commented Aug 9, 2023

@swift-ci Please test

@kimdv
Copy link
Contributor

kimdv commented Aug 9, 2023

@swift-ci Please test windows

@ahoppen ahoppen merged commit 69066f5 into swiftlang:main Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants