Support construction of DeclSyntax subtypes from string interpolation
#2032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the creation of e.g. an `ExtensionDeclSyntax` as
```swift
let extension = try ExtensionDeclSyntax("extension Foo: Proto {}")
```
The initializer throws if the string describes a declaration other than an 'extension'. If the string can get parsed as an extension but contains syntax errors, we return a node that contains syntax errors. This matches the behavior of the `HasTrailingCodeBlock` intializers that take a header + result builder.
|
@swift-ci Please test |
rintaro
reviewed
Aug 8, 2023
Comment on lines
+20
to
+21
| public protocol DeclSyntaxParseable: DeclSyntaxProtocol {} | ||
| public extension DeclSyntaxParseable { |
There was a problem hiding this comment.
What is the reason init(_ stringInterpolation: SyntaxNodeString) can't be just in extension DeclSyntaxProtocol?
There was a problem hiding this comment.
Because, for example, AccessorDeclSyntax does not go through parseDecl, it has its own parser entry function. And thus, trying to call parser.parseDecl and casting it to AccessorDeclSyntax wouldn’t work.
bnbarham
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the creation of e.g. an
ExtensionDeclSyntaxasThe initializer throws if the string describes a declaration other than an 'extension'. If the string can get parsed as an extension but contains syntax errors, we return a node that contains syntax errors. This matches the behavior of the
HasTrailingCodeBlockintializers that take a header + result builder.