Skip to content

Add some documentation for nodes that have unintuitive behavior on first sight #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Aug 7, 2023

Just adds a little documentation for nodes that we know have confused users of SwiftSyntax.

While at it: Don’t generate doc comments for extensions in BuildableCollectionNodesFile.swift. These doc comments served absolutely no purpose.

@ahoppen ahoppen requested a review from bnbarham August 7, 2023 03:59
@ahoppen
Copy link
Member Author

ahoppen commented Aug 7, 2023

@swift-ci Please test

@ahoppen ahoppen force-pushed the ahoppen/node-documentation branch from c3b7e3d to b483d73 Compare August 7, 2023 17:17
@ahoppen
Copy link
Member Author

ahoppen commented Aug 7, 2023

@swift-ci Please test

ahoppen added 2 commits August 7, 2023 13:59
…rst sight

Just adds a little documentation for nodes that we know have confused users of SwiftSyntax.
…esFile.swift`

These doc comments served absolutely no purpose. Remove them.
@ahoppen ahoppen force-pushed the ahoppen/node-documentation branch from b483d73 to 4a89803 Compare August 7, 2023 21:00
@ahoppen
Copy link
Member Author

ahoppen commented Aug 7, 2023

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Aug 7, 2023

@swift-ci Please test Windows

@ahoppen ahoppen merged commit 5412040 into swiftlang:main Aug 8, 2023
@ahoppen ahoppen deleted the ahoppen/node-documentation branch August 8, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants