Rename some SyntaxClassification
#1998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StevenWong12
commented
Aug 4, 2023
| @@ -269,7 +269,7 @@ public class ClassificationTests: XCTestCase { | |||
| assertClassification( | |||
| #"#sourceLocation(file: "x", line: 1)"#, | |||
| expected: [ | |||
| ClassificationSpec(source: "#sourceLocation", kind: .poundDirective), | |||
| ClassificationSpec(source: "#sourceLocation", kind: .identifier), | |||
There was a problem hiding this comment.
I think #sourceLocation being classified as .identifier makes more sense than .ifConfigDirective after the renaming. What do you think?
There was a problem hiding this comment.
I think that keyword might be the best classification, actually.
#sourceLocationis different than macros in that it modifies global state (namely the evaluation of#fileand#linefor all following lines)fileandlineare also classified as keywords- It’s what we get by default, so it’s the least amount of work 😉
|
Here is the corresponding sourcekit-lsp pr. swiftlang/sourcekit-lsp#794 |
ahoppen
reviewed
Aug 4, 2023
| @@ -269,7 +269,7 @@ public class ClassificationTests: XCTestCase { | |||
| assertClassification( | |||
| #"#sourceLocation(file: "x", line: 1)"#, | |||
| expected: [ | |||
| ClassificationSpec(source: "#sourceLocation", kind: .poundDirective), | |||
| ClassificationSpec(source: "#sourceLocation", kind: .identifier), | |||
There was a problem hiding this comment.
I think that keyword might be the best classification, actually.
#sourceLocationis different than macros in that it modifies global state (namely the evaluation of#fileand#linefor all following lines)fileandlineare also classified as keywords- It’s what we get by default, so it’s the least amount of work 😉
StevenWong12
force-pushed
the
rename_syntax_classification
branch
2 times, most recently
from
61c0e74 to
9621a00
Compare
ahoppen
approved these changes
Aug 7, 2023
|
@StevenWong12 There’s a merge conflict. Could you rebase your PR? |
StevenWong12
force-pushed
the
rename_syntax_classification
branch
from
9621a00 to
d7caad1
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
|
Could you trigger the test with swiftlang/sourcekit-lsp#794 again? |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
ahoppen
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename some
SyntaxClassificationand deprecate some out-of-date types.