Disallow the self/Self keyword where it’s not allowed in types
#1986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/disallow-self-in-types
branch
from
056901f to
f75b5fd
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
bnbarham
reviewed
Aug 18, 2023
| DiagnosticSpec(locationMarker: "1️⃣", message: "unexpected 'self' keyword before type"), | ||
| DiagnosticSpec(locationMarker: "2️⃣", message: "expected type", fixIts: ["insert type"]), | ||
| ], | ||
| fixedSource: "<#type#>self" |
There was a problem hiding this comment.
We consume self as unexpected here. I’m not sure if <#type#>.self is really any more useful than what we currently produce, so not sure if it’s worth adding a special case for this recovery.
To put it into context, if you write let a: self, I don’t think that let a: <#type#>.self is a meaningful recovery strategy. We could suggest wrapping self in backticks here, but I’m 100% sure that’s not what the developer intended either.
|
|
||
| assertParse( | ||
| """ | ||
| @derivitave(of: 1️⃣Self.other) |
There was a problem hiding this comment.
Suggested change
| @derivitave(of: 1️⃣Self.other) | |
| @derivative(of: 1️⃣Self.other) |
We weren’t matching the C++ parser’s behavior here. The `self` keyword is not allowed as a type name. `Self` in a nested type refers to a type named `Self` instead of the `Self` keyword.
ahoppen
force-pushed
the
ahoppen/disallow-self-in-types
branch
from
f75b5fd to
d171dc5
Compare
…rse` In many of these places, the test case tested the exact same thing if we didn’t pass a custom `parse` function to `assertParsse`. Default to `SourceFileSyntax.parse` because it produces the more natural diagnostics.
|
@swift-ci Please test |
bnbarham
approved these changes
Aug 21, 2023
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren’t matching the C++ parser’s behavior here. The
selfkeyword is not allowed as a type name.Selfin a nested type refers to a type namedSelfinstead of theSelfkeyword.