Only allow postfixQuestionMark as the question mark after init
#1985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
bnbarham
approved these changes
Aug 2, 2023
ahoppen
force-pushed
the
ahoppen/initializer-optional-mark
branch
2 times, most recently
from
e336e73 to
751fcf7
Compare
|
@swift-ci Please test |
kimdv
approved these changes
Aug 18, 2023
|
@swift-ci Please test macOS |
|
@swift-ci Please test Windows |
|
@swift-ci Please test macOS |
We allowed both `postfixQuestionMark` and `infixQuestionMark` because we didn’t know as which token kind the lexer classified the question mark. But we can just remap the kind in the parser to simplify the syntax node.
ahoppen
force-pushed
the
ahoppen/initializer-optional-mark
branch
from
751fcf7 to
73bb69f
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We allowed both
postfixQuestionMarkandinfixQuestionMarkbecause we didn’t know as which token kind the lexer classified the question mark. But we can just remap the kind in the parser to simplify the syntax node.