Parse hashbang as a child of SourceFileSyntax
#1979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StevenWong12
force-pushed
the
parse_hashbang_as_child_of_sourfile
branch
from
8f39f7a to
99152e4
Compare
ahoppen
reviewed
Aug 7, 2023
StevenWong12
force-pushed
the
parse_hashbang_as_child_of_sourfile
branch
from
99152e4 to
605a5b8
Compare
|
I think we already have an |
Oh, I didn’t see that. Thanks for pointing it out |
|
@swift-ci Please test |
ahoppen
approved these changes
Aug 11, 2023
|
I created a corresponding pr in swiftlang/swift-format#590. Could you trigger CI again? |
|
@swift-ci please test |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1825.
Instead of parsing hashbang into a token list, I think the easier way is to parse the whole as an identifier-like token since we don't care about the content of it.
Also, we could make use of
Lexer.Cursor.advanceToEndOfLineto lex the first line as a hashbang token instead of doing this in the parser.What do you think about it?