Deprecate SyntaxCollection.replacing(childAt:with:) in favor of a writable subscript
#1880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can |
…ritable subscript
ahoppen
force-pushed
the
ahoppen/syntax-collection-index
branch
from
eeff165 to
b852e3c
Compare
Good idea 👍🏽 |
|
@swift-ci Please test |
rintaro
approved these changes
Jul 7, 2023
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The writable subscript fits much better into the current API design of SwiftSyntax instead of the hand-written
replacingfunction, especially if we deprecate all the other hand-written manipulation methods in #1879.