[Macros] Attached macro expansions return single string #1845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
swiftlang/swift#66918 |
rintaro
changed the title
rintaro
force-pushed
the
macros-plugins-collappsed-attached-result
branch
2 times, most recently
from
a8f456a to
3729244
Compare
|
swiftlang/swift#66918 |
|
swiftlang/swift#66918 |
bnbarham
approved these changes
Jun 26, 2023
| attributeNode: attributeNode, | ||
| declarationNode: declarationNode, | ||
| parentDeclNode: parentDeclNode, | ||
| in: context | ||
| ) | ||
| guard let expansions = expansions else { |
There was a problem hiding this comment.
IMO I'd just have this check in the if below, ie.
if let expansions, hostCapability.hasExpandMacroResult {
...
} else {
...
}
|
|
||
| // Create an "oldest" capability. | ||
| init() { | ||
| self.protocolVersion = 0 |
There was a problem hiding this comment.
4 doesn't mean anything in practice. If we use 4 as default, we should add doc-comment explaining that. I don't think it's worth it.
rintaro
force-pushed
the
macros-plugins-collappsed-attached-result
branch
from
3729244 to
23972ec
Compare
* Move collapse(expansions:for:attachedTo:) to SwiftSyntaxMacroExpansion * SwiftSyntaxMacroExpansion.expandAttachedMacro() now perform collapsing * SwiftSyntaxMacroExpansion.expandAttachedMacroWithoutCollapsing() for to keep old behavior * IPC message 'getCapability' now send the host protocol version * Unified IPC response 'macroExpansionResult' that returns single string for both 'expandFreestandingMacro' and 'expandAttachedMacro' * Compiler accepts old 'expandFreestandingMacroResult' and 'expandAttachedMacroResult' to keep compatibility * Plugins check the compiler's protcol version to see if it suppports 'macroExpansionResult', and fall back to old behavior if necessary
Macro deifnition checking is only meant to be used by something that expands macros (e.g. compiler). Not for macro implementation.
rintaro
force-pushed
the
macros-plugins-collappsed-attached-result
branch
from
23972ec to
6fc14cb
Compare
|
swiftlang/swift#66918 |
|
swiftlang/swift#66918 |
DougGregor
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swift-syntax change swiftlang/swift#66918
collapse(expansions:for:attachedTo:)toSwiftSyntaxMacroExpansionSwiftSyntaxMacroExpansion.expandAttachedMacro()now perform collapsingSwiftSyntaxMacroExpansion.expandAttachedMacroWithoutCollapsing()to keep old behaviorgetCapabilitynow sends the host protocol versionmacroExpansionResultthat returns single string for bothexpandFreestandingMacroandexpandAttachedMacroexpandFreestandingMacroResultandexpandAttachedMacroResultto keep compatibilitymacroExpansionResult, and fall back to old behavior if necessaryAlso:
checkMacroDefinition()toSwiftSyntaxMacroExpansionmodule