[WIP] Fix memory corruption bugs in SwiftSyntax #1772
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test macOS |
ahoppen
force-pushed
the
ahoppen/memory-corruption-wip
branch
from
b8052bf to
4d4b2ea
Compare
|
@swift-ci Please test macOS |
ahoppen
force-pushed
the
ahoppen/memory-corruption-wip
branch
from
4d4b2ea to
cbaa25a
Compare
|
@swift-ci Please test macOS |
ahoppen
force-pushed
the
ahoppen/memory-corruption-wip
branch
from
cbaa25a to
90bd233
Compare
The `arena` parameter must be the same one that `raw` is allocated in and ensures that the arena of `raw` doesn’t get deallocated before the `SyntaxData` can retain it. This removes the need for a few `withExtendedLifetime` calls that we had earlier.
ahoppen
force-pushed
the
ahoppen/memory-corruption-wip
branch
from
90bd233 to
aff3411
Compare
|
@swift-ci Please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using this to bisect the CI failure in #1708 that I can’t reproduce locally