Skip to content

[5.9] Fix wrong formatting of multiline string literal #1681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2023
Merged

[5.9] Fix wrong formatting of multiline string literal #1681

merged 1 commit into from
May 23, 2023

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented May 20, 2023 •
edited by ahoppen
Loading

  • Explanation: When diagnosing and adding fix-its for multiline string and when generating with syntax builder it was not adding newline correctly, thus SwiftSyntaxBuilder was generating string literals that weren’t actually valid
  • Scope: diagnostics of multiline string
  • Risk: Medium. There is some breaking changes
  • Testing: Added regression test
  • Issue: rdar://108655349
  • Reviewer: @ahoppen on """ should be inserted on a newline  #1603

@kimdv kimdv requested a review from bnbarham May 20, 2023 06:53
@kimdv kimdv requested a review from ahoppen as a code owner May 20, 2023 06:53
@ahoppen
Copy link
Member

ahoppen commented May 22, 2023

@swift-ci Please test

@ahoppen
Copy link
Member

ahoppen commented May 22, 2023

@kimdv Tests failed on the PR. Could you check why that is?

@kimdv kimdv force-pushed the kimdv/cherry-pick-fix-newline-for-multiline-string-literal branch from a7ebf2f to 5facc4d Compare May 23, 2023 05:34
@kimdv
Copy link
Contributor Author

kimdv commented May 23, 2023

@swift-ci please test

@kimdv
Copy link
Contributor Author

kimdv commented May 23, 2023

@swift-ci please test windows

@kimdv kimdv merged commit 9d63166 into swiftlang:release/5.9 May 23, 2023
@kimdv kimdv deleted the kimdv/cherry-pick-fix-newline-for-multiline-string-literal branch May 23, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

@ahoppen ahoppen ahoppen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kimdv @ahoppen @bnbarham