[5.9] Add support for the copy operator and fix parsing issues around consume #1680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 628a64c)
I followed the same model that we used for consume, namely we need an identifier to copy. This ensures that if we have a function called copy or a variable called copy, we do not break source stability. rdar://101862423 (cherry picked from commit 895977a)
… of move operator and add consume tests. rdar://109413392 (cherry picked from commit 4e2633d)
…ndle consume used as a name in case stmt as pattern match. rdar://109413278 (cherry picked from commit bc84e48)
(cherry picked from commit b3d38fd)
|
swiftlang/swift#66032 is the swift 5.9 commit. |
ahoppen
approved these changes
May 19, 2023
|
MacOS test failure is due to a slight difference in enablement flags on 5.9 vs main: /home/build-user/swift/test/Sema/copy_expr_noimplicit_copy.swift:8:3: error: unexpected error produced: Can not use feature when experimental move only is disabled! Pass the frontend flag -enable-experimental-move-only to swift to enable the usage of this language feature I just fixed that in the other PR |
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will add the CCC later.