[5.9] Reduce SwiftParser’s public surface area #1673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
changed the title
|
@swift-ci Please test |
|
@swift-ci Please test macOS |
ahoppen
force-pushed
the
ahoppen/5.9/parser-not-public
branch
from
cd7b9a2 to
2e07af4
Compare
|
@swift-ci Please test |
Make all `public` functions in SwiftParser that aren’t the parser’s entry functions either SPI or `internal`. Also make a lot of the `RawSyntax` SPI internal. Most of the public functions were never intended to be public.
ahoppen
force-pushed
the
ahoppen/5.9/parser-not-public
branch
from
2e07af4 to
f63a28b
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
bnbarham
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
publicfunctions in SwiftParser that aren’t the parser’s entry functions either SPI orinternal. Also make a lot of theRawSyntaxSPI internal. Most of the public functions were never intended to be public.SwiftParseris removed