Package.swift: make package name consistent with repo name #1647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rest of SwiftPM packages provided by Apple follow a dash-case naming scheme consistent with repository name, usually with `swift-` prefix. This shouldn't have an impact on SwiftSyntax clients. For example `swift-format` already uses `package: "swift-syntax"` argument in its `Package.swift` for specifying the dependency.
|
@swift-ci Please test |
ahoppen
approved these changes
May 9, 2023
|
@swift-ci test |
|
@swift-ci please test windows |
|
@swift-ci test windows |
MaxDesiatov
added a commit
that referenced
this pull request
Jun 14, 2023
Rest of SwiftPM packages provided by Apple follow a dash-case naming scheme consistent with repository name, usually with `swift-` prefix. This shouldn't have an impact on SwiftSyntax clients. For example `swift-format` already uses `package: "swift-syntax"` argument in its `Package.swift` for specifying the dependency. Risk: low, affects only the package display name Original PRs: #1647 for `main` Reviewed by: @ahoppen and @bnbarham Resolves: issue discussed in https://forums.swift.org/t/what-exactly-is-the-real-name-of-this-package/64868 Tests: N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rest of SwiftPM packages provided by Apple follow a dash-case naming scheme consistent with repository name, usually with
swift-prefix.This shouldn't have an impact on SwiftSyntax clients. For example
swift-formatalready usespackage: "swift-syntax"argument in itsPackage.swiftfor specifying the dependency.