support parsing discard in place of _forget
#1644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SE-390 concluded with choosing the keyword `discard` rather than `forget`. This commit begins the process of deprecating the old keyword on the swift-syntax side. rdar://108859077
|
@swift-ci please test |
ahoppen
reviewed
May 9, 2023
Comment on lines
+127
to
+130
| case (.forgetKeyword, let handle)?: // NOTE: support for deprecated _forget | ||
| fallthrough | ||
| case (.discardKeyword, let handle)?: | ||
| return label(self.parseDiscardStatement(discardHandle: handle), with: optLabel) |
There was a problem hiding this comment.
The more swifty way to do write this would be
Suggested change
| case (.forgetKeyword, let handle)?: // NOTE: support for deprecated _forget | |
| fallthrough | |
| case (.discardKeyword, let handle)?: | |
| return label(self.parseDiscardStatement(discardHandle: handle), with: optLabel) | |
| case (.forgetKeyword, let handle)?, | |
| (.discardKeyword, let handle)?: | |
| return label(self.parseDiscardStatement(discardHandle: handle), with: optLabel) |
Comment on lines
+1016
to
+1018
| case .forgetKeyword?: // NOTE: support for deprecated _forget | ||
| fallthrough | ||
| case .discardKeyword?: |
There was a problem hiding this comment.
Same here. fallthrough is discouraged in Swift
Suggested change
| case .forgetKeyword?: // NOTE: support for deprecated _forget | |
| fallthrough | |
| case .discardKeyword?: | |
| case .discardKeyword?, .forgetKeyword?: // NOTE: support for deprecated _forget |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SE-390 concluded with choosing the keyword
discardrather thanforget. This commit begins the process of deprecating the old keyword on the swift-syntax side.rdar://108859077