Skip to content

[5.9] Emit error for unterminated block comment #1631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2023
Merged

[5.9] Emit error for unterminated block comment #1631

merged 1 commit into from
May 4, 2023
+56 −33

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented May 2, 2023

  • Explanation: The new parser was accepting unterminated block comments, which was no good. Add a lever diagnostic for them
  • Scope: Lexing of block comments
  • Risk: We could be rejecting source code in the new parser now, but I think that’s unlikely
  • Testing: Added regression test
  • Issue: rdar://107424615
  • Reviewer: @bnbarham and @hamishknight on Emit error for unterminated block comment #1619

@ahoppen ahoppen requested a review from DougGregor May 2, 2023 21:50
@ahoppen
Copy link
Member Author

ahoppen commented May 2, 2023

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented May 2, 2023

@swift-ci Please test Windows

@ahoppen ahoppen merged commit e2e430a into swiftlang:release/5.9 May 4, 2023
@ahoppen ahoppen deleted the ahoppen/5.9/unterminated-block-comment branch May 4, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahoppen @DougGregor