Skip to content

Fix diagnostic for wrong where in if statement #1616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Apr 28, 2023

No description provided.

@kimdv kimdv requested a review from ahoppen as a code owner April 28, 2023 19:16
@kimdv kimdv force-pushed the kimdv/fix-diagnostic-for-where-keyword-in-if-statement branch from 72dbbaf to 603cd26 Compare April 28, 2023 19:41
@kimdv kimdv force-pushed the kimdv/fix-diagnostic-for-where-keyword-in-if-statement branch from 210f4fe to 4eaddae Compare May 22, 2023 08:00
@kimdv kimdv force-pushed the kimdv/fix-diagnostic-for-where-keyword-in-if-statement branch from 4eaddae to 65d9325 Compare May 22, 2023 08:00
@kimdv
Copy link
Contributor Author

kimdv commented May 22, 2023

@ahoppen this is ready to review now 😁

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM

@ahoppen
Copy link
Member

ahoppen commented May 22, 2023

@swift-ci Please test

@kimdv kimdv merged commit 3ed9dcf into swiftlang:main May 23, 2023
@kimdv kimdv deleted the kimdv/fix-diagnostic-for-where-keyword-in-if-statement branch June 28, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants