Automatically format expanded macros #1591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
force-pushed
the
format-macro-expansions
branch
from
0918abd to
7bc8dda
Compare
|
@swift-ci please test |
rintaro
reviewed
Apr 26, 2023
bnbarham
force-pushed
the
format-macro-expansions
branch
2 times, most recently
from
4d2d3d5 to
efcc899
Compare
|
@swift-ci please test |
bnbarham
force-pushed
the
format-macro-expansions
branch
from
efcc899 to
c5bb157
Compare
|
@swift-ci please test |
ahoppen
approved these changes
Apr 27, 2023
Rather than requiring macro implementations to add required whitespace and indentation, basic format all macro expansions. Right now this uses the default four space indentation, we can consider having that inferred later. Macros can opt-out of automatic formatting by implementing `formatMode` and setting it to `.disabled`. Add new `trimmed(matching:)` and `trimmedDescription(matching:)` methods to allow eg. only trimming whitespace rather than all trivia. Use this when trimming macro expansions so that any added comments are kept. Resolves rdar://107731047.
bnbarham
force-pushed
the
format-macro-expansions
branch
from
c5bb157 to
e40c82c
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than requiring macro implementations to add required whitespace and indentation, basic format all macro expansions. Right now this uses the default four space indentation, we can consider having that inferred later. Macros can opt-out of automatic formatting by implementing
formatModeand setting it to.disabled.Add new
trimmed(matching:)andtrimmedDescription(matching:)methodsto allow eg. only trimming whitespace rather than all trivia. Use this
when trimming macro expansions so that any added comments are kept.
Resolves rdar://107731047.