Skip to content

Fix a couple cases where the formatting in CodeGeneration was off #1561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,10 @@ let parserEntryFile = SourceFileSyntax(leadingTrivia: copyrightHeader) {

let existingUnexpected: [RawSyntax]
if let unexpectedNode = layout.children[layout.children.count - 1] {
precondition(unexpectedNode.is(RawUnexpectedNodesSyntax.self))
existingUnexpected = unexpectedNode.as(RawUnexpectedNodesSyntax.self).elements
precondition(unexpectedNode.is(RawUnexpectedNodesSyntax.self))
existingUnexpected = unexpectedNode.as(RawUnexpectedNodesSyntax.self).elements
} else {
existingUnexpected = []
existingUnexpected = []
}
let unexpected = RawUnexpectedNodesSyntax(elements: existingUnexpected + remainingTokens, arena: self.arena)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -169,11 +169,11 @@ let rawSyntaxNodesFile = SourceFileSyntax(leadingTrivia: copyrightHeader) {
public init(elements: [\(raw: element)], arena: __shared SyntaxArena) {
let raw = RawSyntax.makeLayout(
kind: .\(raw: node.swiftSyntaxKind), uninitializedCount: elements.count, arena: arena) { layout in
guard var ptr = layout.baseAddress else { return }
for elem in elements {
ptr.initialize(to: elem.raw)
ptr += 1
}
guard var ptr = layout.baseAddress else { return }
for elem in elements {
ptr.initialize(to: elem.raw)
ptr += 1
}
}
self.init(unchecked: raw)
}
Expand All @@ -183,7 +183,7 @@ let rawSyntaxNodesFile = SourceFileSyntax(leadingTrivia: copyrightHeader) {
DeclSyntax(
"""
public var elements: [Raw\(raw: node.collectionElementType.syntaxBaseName)] {
layoutView.children.map { Raw\(raw: node.collectionElementType.syntaxBaseName)(raw: $0!) }
layoutView.children.map { Raw\(raw: node.collectionElementType.syntaxBaseName)(raw: $0!) }
}
"""
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,18 +35,18 @@ let rawSyntaxValidationFile = try! SourceFileSyntax(leadingTrivia: copyrightHead
DeclSyntax(
#"""
enum TokenChoice: CustomStringConvertible {
case keyword(StaticString)
case tokenKind(RawTokenKind)
case keyword(StaticString)
case tokenKind(RawTokenKind)

var description: String {
switch self {
case .keyword(let keyword):
return "keyword('\(keyword)')"
case .tokenKind(let kind):
return "\(kind)"
}
}
}
var description: String {
switch self {
case .keyword(let keyword):
return "keyword('\(keyword)')"
case .tokenKind(let kind):
return "\(kind)"
}
}
}
"""#
)

Expand Down Expand Up @@ -76,7 +76,7 @@ let rawSyntaxValidationFile = try! SourceFileSyntax(leadingTrivia: copyrightHead
return (file, line)
case .tokenMismatch(expectedTokenChoices: _, actualKind: _, actualText: _, file: let file, line: let line):
return (file, line)
}
}
}
}
"""#
Expand Down Expand Up @@ -156,13 +156,13 @@ let rawSyntaxValidationFile = try! SourceFileSyntax(leadingTrivia: copyrightHead

DeclSyntax(
#"""
func assertNoError(_ nodeKind: SyntaxKind, _ index: Int, _ error: ValidationError?) {
if let error = error {
let (file, line) = error.fileAndLine
assertionFailure("""
Error validating child at index \(index) of \(nodeKind):
\(error.description)
""", file: file, line: line)
func assertNoError(_ nodeKind: SyntaxKind, _ index: Int, _ error: ValidationError?) {
if let error = error {
let (file, line) = error.fileAndLine
assertionFailure("""
Error validating child at index \(index) of \(nodeKind):
\(error.description)
""", file: file, line: line)
}
}
"""#
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -191,13 +191,12 @@ let syntaxCollectionsFile = SourceFileSyntax(leadingTrivia: copyrightHeader) {
/// - Parameter layout: The new list of raw syntax nodes underlying this
/// collection.
/// - Returns: A new `\(raw: node.name)` with the new layout underlying it.
internal func replacingLayout(
_ layout: [RawSyntax?]) -> \(raw: node.name) {
let arena = SyntaxArena()
let newRaw = layoutView.replacingLayout(with: layout, arena: arena)
let newData = data.replacingSelf(newRaw, arena: arena)
return \(raw: node.name)(newData)
}
internal func replacingLayout(_ layout: [RawSyntax?]) -> \(raw: node.name) {
let arena = SyntaxArena()
let newRaw = layoutView.replacingLayout(with: layout, arena: arena)
let newData = data.replacingSelf(newRaw, arena: arena)
return \(raw: node.name)(newData)
}
"""
)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,12 @@ func syntaxNode(emitKind: String) -> SourceFileSyntax {
DeclSyntax(
"""
let raw = RawSyntax.makeLayout(
kind: SyntaxKind.\(raw: node.swiftSyntaxKind), from: layout, arena: arena,
leadingTrivia: leadingTrivia, trailingTrivia: trailingTrivia)
kind: SyntaxKind.\(raw: node.swiftSyntaxKind),
from: layout,
arena: arena,
leadingTrivia: leadingTrivia,
trailingTrivia: trailingTrivia
)
"""
)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ let triviaPiecesFile = SourceFileSyntax(leadingTrivia: copyrightHeader) {
) {
for trivia in TRIVIAS {
if trivia.isCollection {
DeclSyntax(" case \(raw: trivia.enumCaseName)(Int)")
DeclSyntax("case \(raw: trivia.enumCaseName)(Int)")

} else {
DeclSyntax("case \(raw: trivia.enumCaseName)(SyntaxText)")
Expand Down
Loading