Skip to content

[5.9] Fix wrong diagnostic for generics #1534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

[5.9] Fix wrong diagnostic for generics #1534

wants to merge 0 commits into from

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Apr 13, 2023 •
edited
Loading

  • Explanation: When there was empty generic parameters the parser didn't add correct diagnostics. Also if there was a white space between the left and right angle it crashed.
  • Scope: Parsing of generic parameters
  • Risk: Low, improves diagnostic and fixes crash in parser
  • Testing: CI didn’t find any issues
  • Issue: N/A
  • Reviewer: @ahoppen on Fix wrong diagnostic for generics #1498

@kimdv kimdv requested a review from ahoppen as a code owner April 13, 2023 10:32
@ahoppen
Copy link
Member

ahoppen commented Apr 13, 2023

@swift-ci Please test

@kimdv
Copy link
Contributor Author

kimdv commented Apr 14, 2023

@swift-ci please test Windows

@kimdv kimdv requested a review from bnbarham April 18, 2023 19:08
@kimdv kimdv force-pushed the kimdv/cherry-pick-fix-wrong-diagnostic branch from a198a26 to d3a6e42 Compare April 23, 2023 17:52
@kimdv
Copy link
Contributor Author

kimdv commented May 19, 2023

@swift-ci please test

@kimdv
Copy link
Contributor Author

kimdv commented May 19, 2023

@swift-ci please test windows

@kimdv kimdv closed this May 20, 2023
@kimdv kimdv force-pushed the kimdv/cherry-pick-fix-wrong-diagnostic branch from d3a6e42 to 83c2be9 Compare May 20, 2023 06:40
@kimdv kimdv deleted the kimdv/cherry-pick-fix-wrong-diagnostic branch May 20, 2023 06:43
@kimdv
Copy link
Contributor Author

kimdv commented May 20, 2023

Oh it was cherry picked here: #1576

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

@ahoppen ahoppen Awaiting requested review from ahoppen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kimdv @ahoppen @bnbarham