[5.9] Add diagnostic for wrong where requirements separation #1530
Conversation
kimdv
changed the title
|
@swift-ci please test |
|
@swift-ci Please test Windows |
…-testRecovery177 Add diagnostic for wrong where requirements separation
kimdv
force-pushed
the
kimdv/cherry-pick-add-diagnostic-for-testRecovery177
branch
from
ff230dc to
8ce0e0d
Compare
| @@ -2174,15 +2174,17 @@ final class RecoveryTests: XCTestCase { | |||
| } | |||
|
|
|||
| func testRecovery177() { | |||
| // rdar://38225184 | |||
There was a problem hiding this comment.
This isn't needed any more (I'm fine with just fixing that on main FWIW)
There was a problem hiding this comment.
Just to be clear.
Should it be removed or? 😁
There was a problem hiding this comment.
@bnbarham Just for clarification, this radar number has been carried over from the old parser tests because it was the motivation for the test case. I agree that it has very marginal value by now. I personally don’t have a strong opinion to keeping or removing it.
@kimdv just for your information: The contents of that radar are the same as swiftlang/swift#54086
There was a problem hiding this comment.
Fair enough, personally I'd much prefer a comment on what it's testing rather than a radar number (or the GitHub issue). For something with tonnes of details, sure, link out to the issue. For this though... 🤷
Anyway, I know you didn't add it - it was mostly a drive by comment. No need to fix in this PR.
|
@swift-ci Please test |
|
@swift-ci please test windows |
&&in a generic where requirement the parser didn't recover correctly and emitted a wrong diagnostic. This fix ensures we recover well and have a correct diagnostic and fix-it.