Skip to content

[5.9] Add bazel configuration #1488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

keith
Copy link
Member

@keith keith commented Apr 4, 2023

This allows bazel users to depend on these libraries directly through the SwiftSyntax repo instead of everyone having to provide their own duplicate BUILD files. Since swift-syntax is pretty uniform this is setup using a simple bazel macro that uses the conventions of swiftpm to setup each library. This also includes a bazel target for always building a library with optimizations which can be useful if you want the improved performance and aren't trying to debug swift-syntax itself.

(cherry picked from commit 0a73615)

@keith keith requested a review from ahoppen as a code owner April 4, 2023 04:28
@keith keith mentioned this pull request Apr 4, 2023
@keith
Copy link
Member Author

keith commented Apr 4, 2023

@swift-ci please test

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@keith
Copy link
Member Author

keith commented Apr 4, 2023

@swift-ci please test macOS platform

This allows bazel users to depend on these libraries directly through
the SwiftSyntax repo instead of everyone having to provide their own
duplicate BUILD files. Since swift-syntax is pretty uniform this is
setup using a simple bazel macro that uses the conventions of swiftpm to
setup each library. This also includes a bazel target for always
building a library with optimizations which can be useful if you want
the improved performance and aren't trying to debug swift-syntax itself.

(cherry picked from commit 0a73615)
@keith keith force-pushed the ks/add-bazel-configuration branch from e820776 to c3de8f3 Compare April 4, 2023 18:01
@keith
Copy link
Member Author

keith commented Apr 4, 2023

@swift-ci please test

@keith
Copy link
Member Author

keith commented Apr 4, 2023

@swift-ci please test windows platform

@keith
Copy link
Member Author

keith commented Apr 4, 2023

@swift-ci please test Windows

1 similar comment
@DougGregor
Copy link
Member

@swift-ci please test Windows

@DougGregor
Copy link
Member

@swift-ci please clean test Windows

@keith keith merged commit 5b58ec6 into swiftlang:release/5.9 Apr 5, 2023
@keith keith deleted the ks/add-bazel-configuration branch April 5, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants