Skip to content

Simplify MacroDecl syntax to match the accepted proposals #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 31, 2023
Merged

Simplify MacroDecl syntax to match the accepted proposals #1470

merged 4 commits into from
Mar 31, 2023

Conversation

DougGregor
Copy link
Member

  • Explanation: Early macro proposals differentiated syntax between "function-like" and "value-like" macros. However, we settled on always making macros "function-like", so remove the "value-like" syntax, which causes the parser and syntax tree to be more complex than necessary (and not represent the actual language grammar).
  • Scope: Parser and syntax tree are affected, but no clients ever used this syntax.
  • Risk: Very low; it's eliminating parsing and syntax tree support for an experimental syntax that is no longer in use.
  • Reviewer: @ahoppen

@DougGregor
Simplify MacroDecl syntax to match the accepted proposals
ed16257 
(cherry picked from commit cc41ac4)
@DougGregor
Regenerate sources
db0bc0a 
(cherry picked from commit 7200b19)
@DougGregor
Remove parsing of "value-like" macro declarations
9d75452 
This `macro m: T` macro syntax was present in early macro proposals,
but has not been used in a while and isn't in the accepted form. Remove
it.

(cherry picked from commit 90184c3)
@DougGregor
Reformat
d076303 
(cherry picked from commit baa087e)
@DougGregor DougGregor requested a review from ahoppen as a code owner March 30, 2023 21:58
@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor DougGregor merged commit f2e4643 into swiftlang:release/5.9 Mar 31, 2023
@DougGregor DougGregor deleted the macro-decl-representation-5.9 branch March 31, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen Awaiting requested review from ahoppen ahoppen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DougGregor