-
Notifications
You must be signed in to change notification settings - Fork 439
Added missing fix its #1467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing fix its #1467
Conversation
2032cc1
to
945c466
Compare
945c466
to
b95a0b0
Compare
An assertion message could look like |
b95a0b0
to
2154f15
Compare
I think that’s good enough but if you want to improve it, I won’t stop you. |
c4b42ba
to
146b263
Compare
@ahoppen we need a bit of planning when merging this. I think we then should wait a bit on merging other things, to avoid test start failing because of missing fix-its. |
146b263
to
c71230c
Compare
@swift-ci please test |
@swift-ci please test windows |
@swift-ci please test Windows |
c71230c
to
2b4b4fb
Compare
2b4b4fb
to
c61770d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Adding all those expected Fix-Its must have taken you some time 😆 It’s a great change to better testing. I like it.
One minor comment, otherwise you can try landing it over the weekend.
c61770d
to
2358266
Compare
2358266
to
4357755
Compare
@swift-ci please test |
@swift-ci please test windows |
Not sure if this is needed, but I tought it might be a good idea to compare the fixits we expect and what we actually get.
So just got some examples of where it was missing.
There is still a few hundred places missing.
Also tought that I adding
fixedSource
so we ensure they works in as many scenarios as possible.