add parsing for ~ (the 'without' operator) #1461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
ahoppen
reviewed
Apr 4, 2023
Comment on lines
+1556
to
+1562
| assertParse( | ||
| """ | ||
| struct Hello: ~Copyable {} | ||
|
|
||
| enum Whatever: Int, ~ Hashable, Equatable {} | ||
| """ | ||
| ) |
There was a problem hiding this comment.
Could you create separate assertParse checks for these two cases and make sure they are parsed correctly (i.e. actually have the ~ as a separate token that’s not part of the identifier?
Comment on lines
+232
to
+234
| if self.currentToken.starts(with: "~") { | ||
| withoutToken = self.consumePrefix("~", as: .prefixOperator) | ||
| } |
There was a problem hiding this comment.
Is the ~ part of the identifier? If so, that would surprise me. I would assume that you should be able to do
withoutToken = self.consumeIfContextualPunctuator("~")| /// indicate the suppression of implicit conformance to this type. | ||
| /// This child stores the token representing the 'without' operator. | ||
| Child( | ||
| name: "HasWithout", |
There was a problem hiding this comment.
I would prefer this to be named WithoutTilde. This actually contains the tilde itself, so it’s not a boolean variable, which the Has implies.
ahoppen
pushed a commit
to ahoppen/swift-syntax
that referenced
this pull request
Apr 18, 2023
add parsing for ~ (the 'without' operator)
|
thanks alex for the review. i've addressed them in #1559 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see the primary PR swiftlang/swift#64699 for more details. This companion PR implements the parsing for the "without operator"
~used for conformance suppression. For example,~Copyable.rdar://106775103