Skip to content

Remove gyb files 🥳 #1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 8, 2023
Merged

Remove gyb files 🥳 #1388

merged 2 commits into from
Mar 8, 2023

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Mar 6, 2023

No description provided.

@kimdv kimdv requested a review from ahoppen as a code owner March 6, 2023 10:54
@kimdv
Copy link
Contributor Author

kimdv commented Mar 6, 2023

@swift-ci please test

@kimdv
Copy link
Contributor Author

kimdv commented Mar 6, 2023

The Ci might be updated to not add --gyb-only as a parameter

@ahoppen
Copy link
Member

ahoppen commented Mar 7, 2023

Wohooo 🥳 Nice

You can remove the --gyb-only flag here: Just open a PR for apple/swift and mention it in this PR when requesting CI to trigger cross-PR testing.

https://github.com/apple/swift/blob/8b63ce82730ea60699c86ac7a2d8ea7fcd470f59/utils/swift_build_support/swift_build_support/products/swiftsyntax.py#L82-L88

@kimdv kimdv mentioned this pull request Mar 8, 2023
Merged
@kimdv
Copy link
Contributor Author

kimdv commented Mar 8, 2023

swiftlang/swift#64201

@swift-ci please test

1 similar comment
@kimdv
Copy link
Contributor Author

kimdv commented Mar 8, 2023

swiftlang/swift#64201

@swift-ci please test

@kimdv kimdv force-pushed the kimdv/remove-gyb-files branch from 58a7fe0 to 28a4b6b Compare March 8, 2023 10:37
@kimdv
Copy link
Contributor Author

kimdv commented Mar 8, 2023

swiftlang/swift#64201

@swift-ci please test

ahoppen
ahoppen approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more gyb 🥳

@ahoppen ahoppen merged commit 902ef0b into swiftlang:main Mar 8, 2023
@kimdv kimdv deleted the kimdv/remove-gyb-files branch March 8, 2023 16:42
@DougGregor
Copy link
Member

End of an era, and I love it!

@kimdv
Copy link
Contributor Author

kimdv commented Mar 9, 2023

End of an era, and I love it!

Yes! It have Been fun and challenging.
Next step, take over other repos 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamishknight hamishknight hamishknight left review comments

@ahoppen ahoppen ahoppen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kimdv @ahoppen @DougGregor @hamishknight