Skip to content

Fix leading newline in source file syntax #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Feb 18, 2023

Will fix #1343 (comment)

@kimdv kimdv requested a review from ahoppen as a code owner February 18, 2023 22:20
@kimdv kimdv force-pushed the kimdv/fix-leading-newline-in-source-file-syntax branch from 2615d68 to 5736dbf Compare February 18, 2023 22:39
@kimdv kimdv force-pushed the kimdv/fix-leading-newline-in-source-file-syntax branch from 5736dbf to 8182b90 Compare February 20, 2023 09:27
@ahoppen
Copy link
Member

ahoppen commented Feb 20, 2023

Did you run CodeGeneration after this change? I don’t see the leading newlines before the copyright headers disappear.

@kimdv
Copy link
Contributor Author

kimdv commented Feb 20, 2023

Did you run CodeGeneration after this change? I don’t see the leading newlines before the copyright headers disappear.

WE need to merge this before we can update swift-syntax in CodeGeneration

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@ahoppen
Copy link
Member

ahoppen commented Feb 20, 2023

@swift-ci Please test

@kimdv kimdv merged commit 324166c into swiftlang:main Feb 20, 2023
@kimdv kimdv deleted the kimdv/fix-leading-newline-in-source-file-syntax branch February 20, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants