Resolve switch covers known cases, but 'Enum' may have additional unknown values warnings
#731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…known values` warnings. When building with CMake during the Swift compiler build, the libraries in this package are built with library evolution enabled. That causes the compiler to emit diagnostics that encourage use of `@unknown default` to handle unknown cases that might be added in the future. Silence these warnings by adding `@unknown default` cases where they are missing. Guard these with the `RESILIENT_LIBRARIES` compilation condition to avoid triggering a `Default will never be executed` diagnostic during the package build. Note that this would not be required if `_RegexParser` could always build without library evolution, but that change had to be reverted (rdar://124541877).
|
@swift-ci please test |
|
In order to get this in before the branch I'm going to ask for forgiveness instead of permission and land it now. If anyone has feedback let me know, I'm happy to follow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with CMake during the Swift compiler build, the libraries in this package are built with library evolution enabled. That causes the compiler to emit diagnostics that encourage use of
@unknown defaultto handle unknown cases that might be added in the future. Silence these warnings by adding@unknown defaultcases where they are missing. Guard these with theRESILIENT_LIBRARIEScompilation condition to avoid triggering aDefault will never be executeddiagnostic during the package build.Note that this would not be required if
_RegexParsercould always build without library evolution, but that change had to be reverted (rdar://124541877).