Suppress compiler warnings about Errors with non-Sendable members #727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
force-pushed
the
sendable-errors
branch
from
ea47549 to
44e7c15
Compare
A type conforming to `Error` must be `Sendable`, but `DelimiterLexError` and `CompilerLexError` carry source locations represented by `UnsafeRawPointer`, which is inherently non-`Sendable`. The compiler diagnoses the failure to meet `Sendable` requirements on these error types, which will prevent Swift 6 adoption in `_RegexParser` and also generates build log spam every time the compiler and standard library are built. There are a couple ways to resolve this problem: 1. Refactor so that the errors to not need to carry source locations. 2. Refactor to avoid using `Error` (the code using these errors would not require `Sendable` if it were not for `Error`'s inherent `Sendable` requirement). 3. Suppress the warnings with a `@uncheck Sendable` wrapper. Option 1 probably requires significant refactoring and option 2 seems undesirable since it means that the implementation must forgo the convenience of Swift's error handling model. Therefore this PR implements option 3 as the most expedient way to stop the diagnostic spam, leaving improvement on the status quo as a future exercise.
tshortli
force-pushed
the
sendable-errors
branch
from
44e7c15 to
69fa54d
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows |
natecook1000
pushed a commit
that referenced
this pull request
Mar 8, 2024
Suppress compiler warnings about Errors with non-Sendable members
|
Unless there are exceptional circumstances, please make changes on Updating |
Sorry, I think I'm just very confused about how this is supposed to work in this repo. It looked to me like |
natecook1000
pushed a commit
that referenced
this pull request
Mar 9, 2024
Suppress compiler warnings about Errors with non-Sendable members
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A type conforming to
Errormust beSendable, butDelimiterLexErrorandCompilerLexErrorcarry source locations represented byUnsafeRawPointer, which is inherently non-Sendable. The compiler diagnoses the failure to meetSendablerequirements on these error types, which will prevent Swift 6 adoption in_RegexParserand also generates build log spam every time the compiler and standard library are built. There are a couple ways to resolve this problem:Error(the code using these errors would not requireSendableif it were not forError's inherentSendablerequirement).@unchecked Sendablewrapper.Option 1 probably requires significant refactoring and option 2 seems undesirable since it means that the implementation must forgo the convenience of Swift's error handling model. Therefore this PR implements option 3 as the most expedient way to stop the diagnostic spam, leaving improvement on the status quo as a future exercise.
Also includes a drive-by fix for a trivial, unrelated warning.