[DRAFT] Printable regex #667
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natecook1000
reviewed
May 4, 2023
| } | ||
|
|
||
| @available(macOS 9999, *) // TODO: 5.9? | ||
| public enum RegexSyntax { |
There was a problem hiding this comment.
This should be one of those enum-wrapping structs, since it definitely isn't a closed set.
| let values = try decoder.container(keyedBy: CodingKeys.self) | ||
| let str = try values.decode(String.self, forKey: .string) | ||
| guard let pre = try PrintableRegex(Regex(str)) else { | ||
| throw DecodingError.error |
There was a problem hiding this comment.
Based on my recent proposal experience, this should probably just be the standard DecodingError.typeMismatch. That gets used when a value doesn't decode into the expected type (e.g. an invalid URL).
|
|
||
| @available(macOS 9999, *) // TODO: 5.9? | ||
| extension Regex { | ||
| public var printable: PrintableRegex<Output>? { .init(self) } |
There was a problem hiding this comment.
Do we want to kill two birds with one stone and also provide something like this at the same time?
public var stringRepresentation: String? { PrintableRegex(self).text }
|
Closing in lieu of #670. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.