Skip to content

Change script property default to use Script Extension #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

hamishknight
Copy link
Contributor

Change the default script property behavior for an unqualified value e.g \p{Greek} from \p{Script=Greek} to \p{Script_Extension=Greek}. This is arguably the more intuitive behavior, and matches what Perl does.

Change the default script property behavior for an
unqualified value e.g `\p{Greek}` from
`\p{Script=Greek}` to `\p{Script_Extension=Greek}`.
This is arguably the more intuitive behavior, and
matches what Perl does.
@hamishknight
Copy link
Contributor Author

@swift-ci please test

@hamishknight hamishknight requested review from milseman and Azoy March 2, 2022 17:11
Copy link
Member

@milseman milseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if Perl didn't do it, I'd argue we should. The fact that Perl does it makes this unarguable, IMO.

Copy link
Contributor

@Azoy Azoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hamishknight hamishknight merged commit f11cda8 into swiftlang:main Mar 2, 2022
@hamishknight hamishknight deleted the to-some-extent branch March 2, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants