Support text segment boundary anchors #178
Conversation
This enables the `\y` and `\Y` anchors in regex literals and `Anchor.textSegmentBoundary` in the DSL. Note: This also includes `UnicodeScalar` conformance to `RegexProtocol`, which acts like Unicode scalar literals in regex literals.
|
@swift-ci Please test Linux platform |
|
@swift-ci Please test Linux platform |
| @@ -96,12 +96,16 @@ extension Compiler.ByteCodeGen { | |||
| } | |||
|
|
|||
| case .textSegment: | |||
| // This we should be able to do! | |||
| throw Unsupported(#"\y (text segment)"#) | |||
| builder.buildAssert { (input, pos, _) in | |||
There was a problem hiding this comment.
Are these anchors' semantics dependent on options?
There was a problem hiding this comment.
Yes, the y{g} and y{w} matching options flip the behavior between matching extended grapheme cluster boundaries and word boundaries respectively (with the former being the default). Though it sounds like that's what the TODO is referencing.
| public typealias Match = Substring | ||
|
|
||
| public var regex: Regex<Match> { | ||
| .init(ast: atom(.scalar(self))) |
There was a problem hiding this comment.
We need to stop constructing ASTs in the DSL. Can you use DSLTree, and if not, let me know what's missing?
There was a problem hiding this comment.
Switched this and the other primitives to use DSLTree 👍🏻
|
@swift-ci Please test Linux platform |
|
@swift-ci please test |
Co-authored-by: Michael Ilseman <michael.ilseman@gmail.com>
Co-authored-by: Michael Ilseman <michael.ilseman@gmail.com>
|
@swift-ci Please test Linux platform |
|
@swift-ci Please test Linux platform |
This enables the
\yand\Yanchors in regex literals andAnchor.textSegmentBoundaryin the DSL.Note: This also includes
UnicodeScalarconformance toRegexProtocol, which acts like Unicode scalar literals in regex literals.