Skip to content

Clean up buildBlock(_:) overloads. #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Conversation

rxwei
Copy link
Contributor

@rxwei rxwei commented Feb 10, 2022

  • Remove 9 unused RegexBuilder.buildBlock(_:) overloads.
  • Remove useless @_disfavoredOverload. @_disfavoredOverload is only useful for matching nullary captures when there are overloads for n-ary captures.

@rxwei rxwei requested a review from natecook1000 February 10, 2022 09:54
@rxwei
Copy link
Contributor Author

rxwei commented Feb 10, 2022

@swift-ci please test Linux

@rxwei rxwei force-pushed the builder-cleanup branch 3 times, most recently from 0973583 to a78d641 Compare February 10, 2022 10:01
@rxwei rxwei changed the title Clean up unary buildBlock(_:) overloads. Clean up buildBlock(_:) overloads. Feb 10, 2022
@rxwei
Copy link
Contributor Author

rxwei commented Feb 10, 2022

@swift-ci please test Linux

Copy link
Member

@milseman milseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- Remove 9 unused `RegexBuilder.buildBlock(_:)` overloads.
- Remove useless `@_disfavoredOverload`. `@_disfavoredOverload` is only useful for matching nullary captures when there are overloads for n-ary captures.
@rxwei
Copy link
Contributor Author

rxwei commented Feb 11, 2022

@swift-ci please test Linux

@rxwei rxwei merged commit 0f6525e into swiftlang:main Feb 11, 2022
@rxwei rxwei deleted the builder-cleanup branch February 11, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants