Parse global matching options #133
Conversation
|
@swift-ci please test Linux |
| @@ -34,7 +34,7 @@ extension AST.Node { | |||
| ) -> String { | |||
| var printer = PrettyPrinter() | |||
| printer.printAsCanonical( | |||
| self, | |||
| .init(self, globalOptions: nil), | |||
| delimiters: delimiters, | |||
| terminateLine: terminateLine) | |||
| return printer.finish() | |||
There was a problem hiding this comment.
My intuition is that we then want to hoist this to AST instead of on nodes. The render which takes various options makes sense on the AST so it picks up global options, etc, and the recursive logic is on node.
There was a problem hiding this comment.
There is an overload for AST too, this overload is mainly for convenience e.g a few call sites doing throw unsupported(node.renderAsCanonical()). Though we could reduce the duplication here by having it call into the other overload, let me change that.
| guard ast.root == expectedAST | ||
| || ast.root._dump() == expectedAST._dump() // EQ workaround | ||
| guard ast == expectedAST | ||
| || ast._dump() == expectedAST._dump() // EQ workaround |
There was a problem hiding this comment.
Argh, this is still here! Any chance of adding a bool parameter for something like "ignore trivia", which we can approximate with the dump check? IIRC, this was mostly for trivia like non-semantic whitespace.
There was a problem hiding this comment.
Yeah this is awful, IIRC it's done to ignore both trivia and source location info. We could add a flag, though that wouldn't be sufficient to handle the character class trivia stripping which happens in _dumpBase in #136. Really we ought to strip trivia from the entire tree prior to dumping (or if we strip enough, just compare with ==), or otherwise have a parent type (like PrettyPrinter) that manages the dumping logic as it walks the tree and can store an ignoreTrivia flag. I can look into that in a follow-up.
Parse the PCRE global matching options e.g `(*CR)`, `(*UTF)`, and `(*LIMIT_DEPTH=d)`. Such options may only appear at the very start of the regex, and as such are stored on the top-level AST type.
hamishknight
force-pushed
the
round-again
branch
from
e7cf183 to
8177a3e
Compare
|
@swift-ci please test Linux |
Parse the PCRE global matching options e.g
(*CR),(*UTF), and(*LIMIT_DEPTH=d). Such options may only appear at the very start of the regex, and as such are stored on the top-level AST type.