-
Notifications
You must be signed in to change notification settings - Fork 50
Initial matcher/validator support #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 48 additions & 0 deletions
48
Sources/_StringProcessing/Algorithms/Matching/FirstMatch.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
//===----------------------------------------------------------------------===// | ||
// | ||
// This source file is part of the Swift.org open source project | ||
// | ||
// Copyright (c) 2021-2022 Apple Inc. and the Swift project authors | ||
// Licensed under Apache License v2.0 with Runtime Library Exception | ||
// | ||
// See https://swift.org/LICENSE.txt for license information | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
// MARK: `CollectionSearcher` algorithms | ||
|
||
extension Collection { | ||
public func firstMatch<S: MatchingCollectionSearcher>( | ||
of searcher: S | ||
) -> (S.Match, Range<S.Searched.Index>)? where S.Searched == Self { | ||
var state = searcher.state(for: self, in: startIndex..<endIndex) | ||
return searcher.matchingSearch(self, &state) | ||
} | ||
} | ||
|
||
extension BidirectionalCollection { | ||
public func lastMatch<S: BackwardMatchingCollectionSearcher>( | ||
of searcher: S | ||
) -> (S.Match, Range<S.BackwardSearched.Index>)? | ||
where S.BackwardSearched == Self | ||
{ | ||
var state = searcher.backwardState(for: self, in: startIndex..<endIndex) | ||
return searcher.matchingSearchBack(self, &state) | ||
} | ||
} | ||
|
||
// MARK: Regex algorithms | ||
|
||
extension BidirectionalCollection where SubSequence == Substring { | ||
public func firstMatch<Capture>( | ||
of regex: Regex<Capture> | ||
) -> (Capture, Range<String.Index>)? { | ||
firstMatch(of: RegexConsumer(regex)) | ||
} | ||
|
||
public func lastMatch<Capture>( | ||
of regex: Regex<Capture> | ||
) -> (Capture, Range<String.Index>)? { | ||
lastMatch(of: RegexConsumer(regex)) | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me for now.
Outside scope of this PR, we might make RegexProtocol itself a consumer/searcher/matcher. But, I think it's best to establish parent-child relationships after we have the fundamental model in place. The important thing is getting this code and conformances in.
BTW, why does this need to be public?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some consumer/searcher algorithms return a type generic over the searcher, so the regex overloads return a type generic over
RegexConsumer
. So same story asPredicateConsumer
at the moment.