build: update CMake requirements and simplify #867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake 3.19.0 fixed the compiler invocation requiring the local workaround. Match the runtimes CMake version requirement and drop the workaround.
CMake 3.25 introduced a more consistent way to check what system is being built for. Adopt that uniformly through the build to make it easier to understand.
|
@swift-ci please test |
|
@swift-ci please test Linux platform |
etcwilde
approved these changes
Apr 16, 2025
Co-authored-by: Evan Wilde <etceterawilde@gmail.com>
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
|
@swift-ci please test Linux platform |
1 similar comment
|
@swift-ci please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the minimum required CMake version to match the rest of the Swift toolchain build. This allows us to simplify some of the logic and remove some workarounds that are no longer needed.