avoid overflow in dispatch_io test #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test was failing because number of bytes read overflows int32_t. Changing to a uint32_t is sufficient to avoid overflow. Changing to int64_t would also work, but is a larger change (since we then need to provide an OSAtomicAdd64 function on Linux).
|
you can also use stdatomic ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test was failing because number of bytes read overflows int32_t.
Changing to a uint32_t is sufficient to avoid overflow.
Changing to int64_t would also work, but is a larger change (since
we then need to provide an OSAtomicAdd64 function on Linux).