[swift] Stop using _SwiftDispatchOverlayShims #592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop importing _SwiftDispatchOverlayShims from the Swift stdlib; instead, copy its contents to a new private _DispatchOverlayShims module, and import it with the @_implementationOnly attribute so that clients no longer need to have access to it to merely import Dispatch. The Swift stdlib currently ships the _SwiftDispatchOverlayShims module, but we don't want to keep it there -- it declares APIs that belong to the dispatch project, and it is best maintained by the same people who maintain the library itself. The Dispatch overlay on Darwin has not been importing this module for a couple years now.
|
@swift-ci test |
rokhinip
approved these changes
Feb 8, 2022
lorentey
added a commit
to lorentey/swift
that referenced
this pull request
Feb 8, 2022
This module used to be a private implementation detail of the Distpatch overlay on Apple platforms, and swift-corelibs-libdispatch elsewhere. Darwin hasn't been using this module for a couple years now, and swift-corelibs-dispatch stopped using it with swiftlang/swift-corelibs-libdispatch#592. We are now free to remove it from the Swift toolchain -- which is good, as it contains declarations that are specific to Dispatch, and the compiler/stdlib is not the right place to maintain them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop importing
_SwiftDispatchOverlayShimsfrom the Swift stdlib; instead, copy its contents to a new private_DispatchOverlayShimsmodule, and import it with the@_implementationOnlyattribute so that clients no longer need to have access to it to merelyimport Dispatch.The Swift stdlib currently ships the
_SwiftDispatchOverlayShimsmodule, but we don't want to keep it there -- it consists of declarations that belong to the dispatch project, and it is best maintained by the same people who maintain the library itself.The Dispatch overlay on Darwin has not been importing this module for a couple years now.