Fix unused variable errors #576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variable 'j' is unused in this test and clang emits a warning. `-Werror` is enabled, so this warning is actually emitted as an error.
In only one of the ifdef cases is the `to` variable used. Clang on the rebranch branch recognizes this to be unused on the other branches and emits a warning. This project has `-Werror` enabled, so this results in a build failure. I moved the entire code block down closer to where it is used because it isn't entirely clear based on where it used to sit given the number of macro ifdef's between declaration and usage.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are build errors due to unused variables in two of the tests.
The build system builds these with
-Werrorso instead of a warning, it is a hard failure.This is affecting the swift rebranch work, which has a newer clang that emits warnings in more cases, which is why we are seeing this now.
Failing build log:
https://ci.swift.org/view/Swift%20rebranch/job/oss-swift-rebranch-incremental-RA-linux-ubuntu-18_04/23/console