Skip to content

Fix _libdispatch_tsd_cleanup signature. #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

triplef
Copy link
Contributor

@triplef triplef commented Feb 15, 2021

Fixes the following error when building for Windows x86:

..\src\queue.c(7376,1): error: function declared 'stdcall' here was previously declared without calling convention
_libdispatch_tsd_cleanup(void *ctx)
^
..\src/shims/tsd.h(161,13): note: previous declaration is here
extern void _libdispatch_tsd_cleanup(void *ctx);

DISPATCH_TSD_DTOR_CC is part of the _libdispatch_tsd_cleanup signature in queue.c, but not in the external declaration in tsd.h. DISPATCH_TSD_DTOR_CC resolves to __stdcall on Windows.

@AZero13
Copy link
Contributor

AZero13 commented Aug 31, 2021

@etcwilde we can close this since this was merged already

@triplef
Copy link
Contributor Author

triplef commented Sep 6, 2021

Yup, this was done in #569.

@triplef triplef closed this Sep 6, 2021
@triplef triplef deleted the windows-fixes branch September 6, 2021 12:08
@triplef triplef restored the windows-fixes branch September 6, 2021 12:08
@triplef triplef deleted the windows-fixes branch September 6, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants