build: ensure that we link against the correct library #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that we link against the correct VC runtime libraries. Additionally, enable the macros to indicate that we are linking against the VC runtimes dynamically to get proper DLL storage. This fixes memory issues and file descriptor table synchrony.
|
@swift-ci please test |
|
CC: @ktopley-apple |
ktopley-apple
approved these changes
May 10, 2019
rokhinip
pushed a commit
that referenced
this pull request
Nov 5, 2021
build: ensure that we link against the correct library Signed-off-by: Kim Topley <ktopley@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that we link against the correct VC runtime libraries.
Additionally, enable the macros to indicate that we are linking against
the VC runtimes dynamically to get proper DLL storage. This fixes
memory issues and file descriptor table synchrony.