Swift: correct dispatch source construction on Win32 #479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows uses handles internally for the dispatch sources. Convert the `fileDescriptor` parameter on the incoming point to `HANDLE`s when building the `DispatchSource`. This fixes passing invalid parameters to the Windows system functions.
|
@swift-ci please test |
|
CC: @ktopley-apple |
| @@ -179,7 +182,13 @@ extension DispatchSource { | |||
| #endif | |||
|
|
|||
| public class func makeReadSource(fileDescriptor: Int32, queue: DispatchQueue? = nil) -> DispatchSourceRead { | |||
| let source = dispatch_source_create(_swift_dispatch_source_type_READ(), UInt(fileDescriptor), 0, queue?.__wrapped) | |||
| #if os(Windows) | |||
| let handle: UInt = UInt(_get_osfhandle(fileDescriptor)) | |||
There was a problem hiding this comment.
Strictly speaking you don't need to declare the type here.
ktopley-apple
approved these changes
May 10, 2019
rokhinip
pushed a commit
that referenced
this pull request
Nov 5, 2021
Swift: correct dispatch source construction on Win32 Signed-off-by: Kim Topley <ktopley@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows uses handles internally for the dispatch sources. Convert the
fileDescriptorparameter on the incoming point toHANDLEs whenbuilding the
DispatchSource. This fixes passing invalid parameters tothe Windows system functions.