shims: correct list macros #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @ktopley-apple |
|
@swift-ci please test |
This adjusts the `LIST_ENTRY` to define the structure correctly. This allows for the `LIST_REMOVE` and `LIST_INSERT_HEAD` macros to be defined properly and set the fields previous pointers as well when updating the list. This is needed to enable the use of the macros for list manipulations. Found while implementing file sources for Windows.
compnerd
force-pushed
the
prev-next-prev
branch
from
704d45a to
e9335dd
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
ktopley-apple
approved these changes
Apr 25, 2019
rokhinip
pushed a commit
that referenced
this pull request
Nov 5, 2021
shims: correct list macros Signed-off-by: Kim Topley <ktopley@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts the
LIST_ENTRYto define the structure correctly. Thisallows for the
LIST_REMOVEandLIST_INSERT_HEADmacros to be definedproperly and set the fields previous pointers as well when updating the
list. This is needed to enable the use of the macros for list
manipulations. Found while implementing file sources for Windows.