shims: correct indirection on Windows #451
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `_dispatch_sema4_t` type is a pointer to the handle of the semaphore, so we need to indirect through the pointer before using it. This site was incorrectly using it directly.
|
@swift-ci please test |
|
@ktopley-apple - not so sure about this making things more complicated. This fixes a bug in libdispatch (which also exists in 1121) and improves the usage of it for XCTest on Windows. However, not sure if this complicates the merge. If not, it would be great to get this merged. |
|
@swift-ci please test |
|
@swift-ci please testt |
MadCoder
approved these changes
Mar 7, 2019
|
This is included in the windows improvements, lets just go with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_dispatch_sema4_ttype is a pointer to the handle of thesemaphore, so we need to indirect through the pointer before using it.
This site was incorrectly using it directly.