dispatch: include time.h on windows
#430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
time.h is needed on Windows to ensure that we have a definition of `timespec`. This is needed when building the swift SDK overlay. It seems that when cross-compiling, we were getting lucky with the `timespec` definition being provided by some other header being included. This repairs the build of libdispatch's swift SDK overlay on Windows targeting Windows.
|
@swift-ci please test |
ktopley-apple
approved these changes
Nov 26, 2018
rokhinip
pushed a commit
that referenced
this pull request
Nov 5, 2021
dispatch: include `time.h` on windows Signed-off-by: Kim Topley <ktopley@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
time.h is needed on Windows to ensure that we have a definition of
timespec. This is needed when building the swift SDK overlay. Itseems that when cross-compiling, we were getting lucky with the
timespecdefinition being provided by some other header beingincluded. This repairs the build of libdispatch's swift SDK overlay on
Windows targeting Windows.