build improvements #429
Merged
build improvements #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the swift support CMake rules from XCTest. This adds support for additional features like partial module compilation which improves incremental builds. It allows for executable and library builds.
Enhance add_wift_target to support building static libraries. We would always generate shared libraries previously.
This is needed to enable Windows to actually link against swiftDispatch to build code. When building against a distribution image rather than the build tree, this comes to light.
We did not distribute generic_win_base.h which prevents the CDispatch module from being built when building against a distribution image.
We did not disable exceptions when building with cl, do so like we do with the GCC style driver.
Windows splits the installation into the library directory (for the import library) and the runtime component (dll) which is installed into bin. This makes the Windows build happier.
|
@swift-ci please test |
|
CC: @spevans - this should have all the changes to properly build and install the static and shared versions of libdispatch. Would you mind taking on the changes to build-script-impl to get that resolved? |
ktopley-apple
approved these changes
Nov 26, 2018
rokhinip
pushed a commit
that referenced
this pull request
Nov 5, 2021
build improvements Signed-off-by: Kim Topley <ktopley@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the build for Windows, making the installed image usable for building on Windows target from a distributed toolchain. It also cleans up some of the build for static library construction and re-synchronises with XCTest (resource bundling was not supported, but this is mostly for synchrony and not because it is used).