Add string.h for memcpy in Data.swift. #426
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Data.swift the C function memcpy is used as part of _copyBytesHelper. The function is defined in string.h, but that header is not referenced directly by any of the headers in dispatch/ or by DispatchOverlayShims.h in the compiler, which are the only two headers imported by the swift file. For some reason, this is working on Darwin and Ubuntu, probably because some included header includes string.h or defines memcpy, avoiding the problem. For those platforms that this already works, adding an extra include should not affect them.
|
@swift-ci please test |
rokhinip
pushed a commit
that referenced
this pull request
Nov 5, 2021
Add string.h for memcpy in Data.swift. Signed-off-by: Kim Topley <ktopley@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
Data.swiftthe C functionmemcpyis used as part of_copyBytesHelper.The function is declared in
string.h, but that header is not referenceddirectly by any of the headers in
dispatch/or byDispatchOverlayShims.hin the compiler, which are the only two headers imported by the swift
file.
For some reason, this is working on Darwin and Ubuntu, probably because
some included header includes
string.hor declaresmemcpy, avoiding theproblem. For those platforms that this already works, adding an extra
include should not affect them.