Stub out unimplemented Windows functions #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadCoder
suggested changes
Jun 23, 2018
src/shims/generic_win_stubs.c
Outdated
| } | ||
|
|
||
| void | ||
| _dispatch_event_loop_wait_for_ownership( |
There was a problem hiding this comment.
for this family of functions, you should instead start a: src/event/event_windows.c and copy the functions from event_epoll.c that do nothing and or assert.
they will likely not have an implementation on windows for a while in the first place.
Provide stubs for unimplemented Windows functions so that dispatch.dll can link and we can start building the tests. If one of these stubs is called, it will be reported to the CRT.
|
Updated to put event functions in an event_windows.c. |
MadCoder
approved these changes
Jun 27, 2018
|
@swift-ci please test |
ktopley-apple
pushed a commit
that referenced
this pull request
Dec 6, 2018
Stub out unimplemented Windows functions Signed-off-by: Kim Topley <ktopley@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide stubs for unimplemented Windows functions so that dispatch.dll can link
and we can start building the tests. If one of these stubs is called, it will be
reported to the CRT.