BlocksRuntime: match the ABI specification for LLP64 #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Blocks ABI v1 defined the `size` and `reserved` fields as `unsigned long int` rather than `uintptr_t`. This breaks on LLP64 hosts where `uintptr_t` is larger than `unsigned long int`. Make this conform to the specification.
|
CC: @MadCoder |
|
@swift-ci please test |
ktopley-apple
pushed a commit
that referenced
this pull request
Dec 6, 2018
BlocksRuntime: match the ABI specification for LLP64 Signed-off-by: Kim Topley <ktopley@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Blocks ABI v1 defined the
sizeandreservedfields asunsigned long intrather thanuintptr_t. This breaks on LLP64 hosts whereuintptr_tis larger thanunsigned long int. Make this conform tothe specification.