Report crash messages on Windows to the CRT #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide a Windows implementation of the _dispatch_set_crash_log_* macros which pass the crash message to the CRT using _RPTF0. If libdispatch is linked against a debug version of msvcrt, this will display a dialog with detailed information about the crash and provide an option to attach a debugger. On release versions of msvcrt, this reporting is a no-op.
|
this is exactly how it's meant to be used, excellent! |
|
@swift-ci please test |
MadCoder
approved these changes
Jun 20, 2018
ktopley-apple
pushed a commit
that referenced
this pull request
Dec 6, 2018
Report crash messages on Windows to the CRT Signed-off-by: Kim Topley <ktopley@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a Windows implementation of the
_dispatch_set_crash_log_*macros whichpass the crash message to the CRT using _RPTF0. If libdispatch is linked against
a debug version of msvcrt, this will display a dialog with detailed information
about the crash and provide an option to attach a debugger. On release versions
of msvcrt, this reporting is a no-op.
Example of what this dialog looks like (from an actual issue I encountered):